Improve CI/CD workflows (and support merge queues)#45
Merged
HappyPaul55 merged 2 commits intomainfrom May 21, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CI/CD workflows to streamline releases, builds, and deployments while adding support for merge queues. Key changes include:
- Introduction of new subworkflows for release, deploy, and build operations.
- Addition of main_merge and feature_build workflows to support merge queues.
- Removal of outdated pr_build and branch_build workflows.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/subworkflow-release.yml | Adds a release workflow that creates a safe package and conditionally deploys to Deskpro Infrastructure. |
| .github/workflows/subworkflow-deploy.yml | Defines a deploy workflow using Docker SSH context and container operations. |
| .github/workflows/subworkflow-build.yml | Introduces a build workflow that handles linting, testing, building, and tagging of the project. |
| .github/workflows/main_merge.yml | Integrates build and release operations into a main merge workflow. |
| .github/workflows/feature_build.yml | Adds a feature build workflow supporting merge queues for pull requests. |
| .github/workflows/pr_build.yml | Removed outdated PR build workflow. |
| .github/workflows/branch_build.yml | Removed outdated branch build workflow. |
| working-directory: app-package | ||
| run: | | ||
| packageFilename=`jq -r .name manifest.json | iconv -t ascii//TRANSLIT | sed -r s/[~\^]+//g | sed -r s/[^a-zA-Z0-9]+/-/g | sed -r s/^-+\|-+$//g | tr A-Z a-z` | ||
| mv app.zip $packageFilename.zip |
There was a problem hiding this comment.
Consider quoting the target filename to handle potential spaces in the variable value, for example: mv app.zip "$packageFilename.zip".
Suggested change
| mv app.zip $packageFilename.zip | |
| mv app.zip "$packageFilename.zip" |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Build for commit aec9aa8 deployed to: https://nutshell-pr-45.ci.next.deskprodemo.com URLs: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.